crypto: reject inherited key type names#62875
Merged
nodejs-github-bot merged 3 commits intonodejs:mainfrom Apr 23, 2026
Merged
Conversation
Use an own-property check when dispatching generateKeyPair's NID-only algorithm table Fixes: nodejs#62874 Signed-off-by: Jonathan Lopes <jonathan15989@protonmail.com>
Collaborator
|
Review requested:
|
nodejs-github-bot
added
crypto
panva
reviewed
Apr 21, 2026
Contributor
Author
|
Sure, I'll change it and send it right away. |
Signed-off-by: Jonathan Lopes <jonathan15989@protonmail.com>
panva
added
the
commit-queue-squash
addaleax
approved these changes
Apr 21, 2026
addaleax
added
author ready
panva
removed
request-ci
Signed-off-by: Jonathan Lopes <jonathan15989@protonmail.com>
panva
approved these changes
Apr 21, 2026
panva
added
author ready
Member
|
Thank you for the quick turnaround @JonathanLopes404 |
github-actions
Bot
removed
the
request-ci
This comment was marked as outdated.
This comment was marked as outdated.
Codecov Reportβ
All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #62875 +/- ##
==========================================
+ Coverage 89.61% 89.62% +0.01%
==========================================
Files 706 706
Lines 219144 219145 +1
Branches 41985 41981 -4
==========================================
+ Hits 196391 196417 +26
- Misses 14629 14636 +7
+ Partials 8124 8092 -32
π New features to boost your workflow:
|
Collaborator
panva
added
the
commit-queue
Member
|
@JonathanLopes404 thank you for the contribution, since we now have a passing GHA as well as Jenkins CI and two collaborator β
I've applied
commit-queue
|
nodejs-github-bot
added
commit-queue-failed
Collaborator
Commit Queue failed- Loading data for nodejs/node/pull/62875 β Done loading data for nodejs/node/pull/62875 ----------------------------------- PR info ------------------------------------ Title crypto: reject inherited key type names (#62875) β Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch JonathanLopes404:fix/issue-62874 -> nodejs:main Labels crypto, author ready, needs-ci, commit-queue-squash Commits 3 - crypto: reject inherited key type names - crypto: add __proto__ null to nidOnlyKeyPairs - crypto: fix lint errors Committers 1 - Jonathan <jonathan15989@protonmail.com> PR-URL: https://github.com/nodejs/node/pull/62875 Fixes: https://github.com/nodejs/node/issues/62874 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Filip Skokan <panva.ip@gmail.com> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/62875 Fixes: https://github.com/nodejs/node/issues/62874 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Filip Skokan <panva.ip@gmail.com> -------------------------------------------------------------------------------- βΉ This PR was created on Tue, 21 Apr 2026 16:16:54 GMT β Approvals: 2 β - Anna Henningsen (@addaleax): https://github.com/nodejs/node/pull/62875#pullrequestreview-4149384071 β - Filip Skokan (@panva) (TSC): https://github.com/nodejs/node/pull/62875#pullrequestreview-4149430105 β Last GitHub CI successful βΉ Last Full PR CI on 2026-04-21T18:24:07Z: https://ci.nodejs.org/job/node-test-pull-request/72834/ - Querying data for job/node-test-pull-request/72834/ β Build data downloaded β Last Jenkins CI successful -------------------------------------------------------------------------------- β No git cherry-pick in progress β No git am in progress β No git rebase in progress -------------------------------------------------------------------------------- - Bringing origin/main up to date... From https://github.com/nodejs/node * branch main -> FETCH_HEAD β origin/main is now up-to-date - Downloading patch for 62875 error: RPC failed; HTTP 500 curl 22 The requested URL returned error: 500 fatal: expected flush after ref listinghttps://github.com/nodejs/node/actions/runs/24847374924 |
panva
added
commit-queue
nodejs-github-bot
removed
the
commit-queue
Collaborator
|
Landed in 800f582 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use an own-property check when dispatching generateKeyPair's NID-only algorithm table
Fixes: #62874